-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update builtins.md #4714
Update builtins.md #4714
Conversation
When running this macro as it was it never gets to the finally part because it always returns when building the `rel` variable.
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
testing this today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and return may be removed as it's not mandatory. cc @dbeatty10
thank you for opening this @loganstartoni ! i appreciate you clarifying the docs and I'll get this merged for you. looking forward to future contributions! ✨
What are you changing in this pull request and why?
When running this macro as it was it never gets to the finally part because it always returns when building the
rel
variable.I was not able to use the code as is when trying to override the function because I was trying to edit the relation to not include the db or schema, but the code to override the relation was never ran because of the early returns.
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/static/_redirects
npm run build
to update the links that point to deleted pages