Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builtins.md #4714

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Update builtins.md #4714

merged 8 commits into from
Jan 12, 2024

Conversation

loganstartoni
Copy link
Contributor

@loganstartoni loganstartoni commented Jan 5, 2024

What are you changing in this pull request and why?

When running this macro as it was it never gets to the finally part because it always returns when building the rel variable.

I was not able to use the code as is when trying to override the function because I was trying to edit the relation to not include the db or schema, but the code to override the relation was never ran because of the early returns.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

When running this macro as it was it never gets to the finally part because it always returns when building the `rel` variable.
@loganstartoni loganstartoni requested a review from a team as a code owner January 5, 2024 15:44
Copy link

welcome bot commented Jan 5, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 1:39pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 5, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 5, 2024
@mirnawong1
Copy link
Contributor

testing this today

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and return may be removed as it's not mandatory. cc @dbeatty10

thank you for opening this @loganstartoni ! i appreciate you clarifying the docs and I'll get this merged for you. looking forward to future contributions! ✨

@mirnawong1 mirnawong1 merged commit 884857f into dbt-labs:current Jan 12, 2024
4 checks passed
@loganstartoni loganstartoni deleted the patch-1 branch March 31, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content January-2024 new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants