Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO_NOT_TRACK=0 is not the same as DBT_SEND_ANONYMOUS_USAGE_STATS=True #4713

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jan 4, 2024

What are you changing in this pull request and why?

While responding to dbt-labs/dbt-core#9336, I set DO_NOT_TRACK=0 and examined the result. It does not behave the same way as DBT_SEND_ANONYMOUS_USAGE_STATS=True.

Looking at the source code here explains why.

So we can safely just remove this line from the docs for send_anonymous_usage_stats to avoid confusion.

Additional info

We first added support for the Console Do Not Track initiative within dbt-labs/dbt-core#5000 as described in dbt-labs/dbt-core#3540.

Any of the following are equivalent to DBT_SEND_ANONYMOUS_USAGE_STATS=False (whether they are uppercase, lowercase, or mixed case):

export DO_NOT_TRACK=1
export DO_NOT_TRACK=t
export DO_NOT_TRACK=true
export DO_NOT_TRACK=y
export DO_NOT_TRACK=yes

Any other values of DO_NOT_TRACK are ignored altogether and not have any effect.

Checklist

@dbeatty10 dbeatty10 requested a review from a team as a code owner January 4, 2024 22:16
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 10:56am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 4, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and thank you for opening this up @dbeatty10 !

@mirnawong1 mirnawong1 enabled auto-merge January 8, 2024 10:54
@mirnawong1 mirnawong1 merged commit 0c740b6 into current Jan 8, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/do-not-track-environment-variable branch January 8, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content January-2024 size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants