Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cumulative-metrics.md #4705

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Update cumulative-metrics.md #4705

merged 5 commits into from
Jan 8, 2024

Conversation

rpourzand
Copy link
Contributor

I found a typo while looking at cumulative metrics docs. I think the "cannot be used.." should be switched

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

I found a typo while looking at cumulative metrics docs. I think the "cannot be used.." should be switched
@rpourzand rpourzand requested a review from Jstein77 January 3, 2024 23:40
@rpourzand rpourzand requested a review from a team as a code owner January 3, 2024 23:40
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 10:52am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 3, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @rpourzand ! Great catch and thank you for opening this up!

@mirnawong1
Copy link
Contributor

going to merge this now @rpourzand and @Jstein77

@mirnawong1 mirnawong1 enabled auto-merge January 8, 2024 10:47
@mirnawong1 mirnawong1 merged commit 0d19b21 into current Jan 8, 2024
6 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-cumulative-typo branch January 8, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content January-2024 size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants