-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callout to PrivateLink docs about Environment Variables #4701
Add callout to PrivateLink docs about Environment Variables #4701
Conversation
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @ryancharris! made some very small tweaks and thank you so much for opening up your very first PR and using the partials ✨ ! let me know if you have any thoughts and will get this merged for you!
approved from the docs side, however this PR needs to be reviewed and approved by the other multi-cell teammates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryancharris this looks good, thanks for updating this! I believe we can add this snippet for Snowflake too?
Edit: Extended attributes will work for Snowflake, however the field that would get updated is account
rather than hostname
.
0b3ee2d
to
39c6248
Compare
@@ -0,0 +1,5 @@ | |||
:::caution Environment variables | |||
|
|||
Using [Environment variables](/docs/build/environment-variables) when configuring PrivateLink endpoints isn't supported in dbt Cloud. Instead, use [Extended Attributes](/docs/deploy/deploy-environments#extended-attributes) to dynamically change these values in your dbt Cloud environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only sorta true, since it technically works in ST. There's some nuance I guess though in that in ST, you dont configure to use a PL endpoint in-app, where as you do in MT. Do we foresee this causing extra confusion/issues for customers due to this difference?
To be clear though, I'm more than happy for us to just say across the board, regardless of ST vs MT, that we just dont want folks to use env vars for their connection hostnames if they use PL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
39c6248
to
5263dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
What are you changing in this pull request and why?
This PR adds a callout snippet regarding the limitation in terms of using custom Environment Variables to populate the
hostname
of a PrivateLink endpoint (for the warehouses that support it). This is not supported in dbt Cloud and the suggested workaround is to use Extended Attributes.Instructions were updated for:
Instructions were not updated for:
MUL-512
Checklist