-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exports content and rn #4689
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving outstanding questions (sorry they're in caps)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding comments
|
||
If exports aren't needed, you can set the value(s) to `FALSE` (`DBT_INCLUDE_SAVED_QUERY=FALSE`). | ||
|
||
<Lightbox src="/img/docs/dbt-cloud/semantic-layer/deploy_exports.jpg" width="90%" title="Add an environment variable to run exports in your production run." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jstein77 i updated teh screenshot so it's super clear that the key only contains DBT_INCLUDE_SAVED_QUERY
and users don't make the same mistake i did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! non-blocking nits
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
this pr is to prepare for the SL exports functionality that the team have communicated with users.
This is still a wip and needs more context.
Checklist: