Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo caching #4684

Merged
merged 11 commits into from
Dec 21, 2023
Merged

Update repo caching #4684

merged 11 commits into from
Dec 21, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Dec 20, 2023

What are you changing in this pull request and why?

Update repo caching section below so it includes info about the situations when dbt Cloud uses the cached copy instead

https://docs.getdbt.com/docs/deploy/deploy-environments#git-repository-caching

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner December 20, 2023 21:25
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 9:14pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Dec 20, 2023
@nghi-ly nghi-ly requested a review from dbactual December 20, 2023 23:23
@@ -42,6 +42,13 @@ For improved reliability and performance on your job runs, you can enable dbt Cl

dbt Cloud caches your project's Git repo after each successful run and retains it for 8 days if there are no repo updates. It caches all packages regardless of installation method and does not fetch code outside of the job runs.

Below lists the situations when dbt Cloud uses the cached copy:

- Outages from third-party services (for example, your Git provider).
Copy link
Contributor

@mirnawong1 mirnawong1 Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a non git related service to be extra explicit

Suggested change
- Outages from third-party services (for example, your Git provider).
- Outages from third-party services (for example, the [dbt package hub](https://hub.getdbt.com/)).

@nghi-ly nghi-ly requested a review from mirnawong1 December 21, 2023 21:10
@@ -42,6 +42,13 @@ For improved reliability and performance on your job runs, you can enable dbt Cl

dbt Cloud caches your project's Git repo after each successful run and retains it for 8 days if there are no repo updates. It caches all packages regardless of installation method and does not fetch code outside of the job runs.

dbt Cloud will use the cached copy of your project's Git repo under these circumstances:

- Outages from third-party services (for example, the [dbt package hub](https://hub.getdbt.com/)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it is helpful to have another example, on top of your git one. so adding the git bc that's def a big example that would be helpful for users to know

Suggested change
- Outages from third-party services (for example, the [dbt package hub](https://hub.getdbt.com/)).
- Outages from third-party services (for example, your Git provider or the [dbt package hub](https://hub.getdbt.com/)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Git example is actually mentioned in the screenshot so we're good there

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocker suggestion and am approving to not block you. lgtm and repo caching is so cool!

@nghi-ly nghi-ly merged commit 2451184 into current Dec 21, 2023
7 checks passed
@nghi-ly nghi-ly deleted the ly-docs-repo-caching-use-cases branch December 21, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants