-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snowflake-setup.md #4680
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
remove v from version
website/docs/docs/cloud/connect-data-platform/connect-snowflake.md
Outdated
Show resolved
Hide resolved
website/docs/docs/cloud/connect-data-platform/connect-snowflake.md
Outdated
Show resolved
Hide resolved
website/docs/docs/core/connect-data-platform/snowflake-setup.md
Outdated
Show resolved
Hide resolved
website/docs/docs/core/connect-data-platform/snowflake-setup.md
Outdated
Show resolved
Hide resolved
hey @patkearns10 some small tweaks in terms of language. also do you think the following example in the cloud doc needs updating so 'encrypted' is removed since 0.16.0 is a deprecated/unsupported version?
|
hey @patkearns10 let me know if you have any questions or thoughts 🙏 |
…e.md Co-authored-by: mirnawong1 <[email protected]>
…e.md Co-authored-by: mirnawong1 <[email protected]>
Co-authored-by: mirnawong1 <[email protected]>
Co-authored-by: mirnawong1 <[email protected]>
I think we should keep this example because customers might still choose to use an encrypted private key, so those comments would still be required |
website/docs/docs/cloud/connect-data-platform/connect-snowflake.md
Outdated
Show resolved
Hide resolved
website/docs/docs/core/connect-data-platform/snowflake-setup.md
Outdated
Show resolved
Hide resolved
website/docs/docs/cloud/connect-data-platform/connect-snowflake.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @patkearns10
What are you changing in this pull request and why?
https://dbt-labs.slack.com/archives/C04KKUHLT32/p1702917286747549
https://github.com/dbt-labs/dbt-cloud/pull/9675
Passphrase should be optional and are not required in the frontend (or in profiles since dbt 0.16.0), but we were requiring them when generating profiles. Updating the docs to say only provide when necessry.
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js
Removing or renaming existing pages (delete if not applicable):
website/sidebars.js
website/static/_redirects
npm run build
to update the links that point to the deleted page