Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snowflake-setup.md #4680

Merged
merged 14 commits into from
Dec 22, 2023
Merged

Conversation

patkearns10
Copy link
Contributor

@patkearns10 patkearns10 commented Dec 20, 2023

What are you changing in this pull request and why?

https://dbt-labs.slack.com/archives/C04KKUHLT32/p1702917286747549
https://github.com/dbt-labs/dbt-cloud/pull/9675
Passphrase should be optional and are not required in the frontend (or in profiles since dbt 0.16.0), but we were requiring them when generating profiles. Updating the docs to say only provide when necessry.

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to the deleted page

@patkearns10 patkearns10 requested a review from a team as a code owner December 20, 2023 03:23
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 4:51pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 20, 2023
@mirnawong1
Copy link
Contributor

hey @patkearns10 some small tweaks in terms of language. also do you think the following example in the cloud doc needs updating so 'encrypted' is removed since 0.16.0 is a deprecated/unsupported version?

-----BEGIN ENCRYPTED PRIVATE KEY-----
< encrypted private key contents here - line 1 >
< encrypted private key contents here - line 2 >
< ... >
-----END ENCRYPTED PRIVATE KEY-----

@mirnawong1
Copy link
Contributor

hey @patkearns10 let me know if you have any questions or thoughts 🙏

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Dec 22, 2023
@patkearns10
Copy link
Contributor Author

hey @patkearns10 some small tweaks in terms of language. also do you think the following example in the cloud doc needs updating so 'encrypted' is removed since 0.16.0 is a deprecated/unsupported version?

-----BEGIN ENCRYPTED PRIVATE KEY-----
< encrypted private key contents here - line 1 >
< encrypted private key contents here - line 2 >
< ... >
-----END ENCRYPTED PRIVATE KEY-----

I think we should keep this example because customers might still choose to use an encrypted private key, so those comments would still be required

Copy link
Contributor

@matthewshaver matthewshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @patkearns10

@matthewshaver matthewshaver merged commit ec10419 into current Dec 22, 2023
7 checks passed
@matthewshaver matthewshaver deleted the patkearns10-snowflake-passphrase branch December 22, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants