detailsToggle fast follow #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
size: small
JKarlavige
approved these changes
Dec 18, 2023
|
awesome! thank you sooo much @JKarlavige ! |
For sure, nice work on the fix!! |
|
adding this slack convo for more context and explaination |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates the code i the following sections because the ux was a little weird if you immediately clicked on the toggle after it expanded:
handleToggleClickflips the current open/close state (!current), and ensures hover is always active.handleMouseEnterchecks if the content is already open (isOn) before enabling hoverhandleMouseLeaveenables so that the content closes only if it's not already open due to a click.