Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic default incremental_strategy for dbt-postgres and dbt-redshift #4652

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Dec 14, 2023

resolves #4651

Previews

What are you changing in this pull request and why?

The default incremental_strategy for dbt-postgres and dbt-redshift is dynamic!

It depends on if unique_key is defined or not:

  • delete_insert when there is a unique_key defined and append otherwise

All other adapters have a static default incremental_strategy.

🎩

image

Checklist

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 7:10pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 14, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Dec 14, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review December 14, 2023 15:07
@dbeatty10 dbeatty10 requested review from dataders and a team as code owners December 14, 2023 15:07
@matthewshaver
Copy link
Contributor

Thank you @dbeatty10 !

@matthewshaver matthewshaver merged commit c9b6cfd into current Dec 14, 2023
7 checks passed
@matthewshaver matthewshaver deleted the dbeatty/dynamic-default-postgres-redshift branch December 14, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain how default incremental_strategy is determined for dbt-postgres and dbt-redshift
2 participants