Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial parsing UI #4646

Merged
merged 64 commits into from
Jan 5, 2024
Merged

Partial parsing UI #4646

merged 64 commits into from
Jan 5, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Dec 14, 2023

What are you changing in this pull request and why?

Add new Partial parsing option in dbt Cloud

Checklist

Adding new pages (delete if not applicable):

  • [ ] Add page to website/sidebars.js N/A automated for new release note
  • Provide a unique filename for the new page

@nghi-ly nghi-ly requested a review from a team as a code owner December 14, 2023 00:42
@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Dec 14, 2023
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 3:29pm

@@ -34,24 +34,6 @@ Both development and deployment environments have a section called **General Set
- If you select a current version with `(latest)` in the name, your environment will automatically install the latest stable version of the minor version selected.
:::

### Git repository caching
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section was moved (not deleted) to reorder the four H3 subsections to be alphabetical

- certain widely-used macros, e.g. [builtins](/reference/dbt-jinja-functions/builtins) overrides or `generate_x_name` for `database`/`schema`/`alias`
- certain widely-used macros (for example, [builtins](/reference/dbt-jinja-functions/builtins), overrides, or `generate_x_name` for `database`/`schema`/`alias`)

If you're triggering [CI](/docs/deploy/continuous-integration) job runs, the partial parsing benefits are not available on a new pull request (PR) or new branch. However, they are available on subsequent commits to that new PR or branch.
Copy link
Contributor Author

@nghi-ly nghi-ly Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line was added per this Notion block

Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@thorn14 thorn14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Ignore my request for an additional callout, I think this is fine.

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one non-blocking suggestion, but looks great!

website/snippets/_cloud-environments-info.md Show resolved Hide resolved
@nghi-ly nghi-ly merged commit 136348c into current Jan 5, 2024
4 checks passed
@nghi-ly nghi-ly deleted the ly-docs-partial-parse-ui branch January 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs January-2024 size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants