Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the valid and default strategies are up-to-date and accurate per adapter #4638

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Ensure that the valid and default strategies are up-to-date and accurate per adapter #4638

merged 5 commits into from
Dec 13, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Dec 13, 2023 •
edited
Loading

resolves #4633

Preview

What are you changing in this pull request and why?

  • merge has been the default since dbt-databricks 1.0.0
  • For readability, removing references to "Delta only" since those were added in #77 (April 2020) and not updated since then to reflect additions of Hudi and Iceberg
    • Opened #4639 to follow-up on the details

🎩

image

Checklist

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 8:09pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 13, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Dec 13, 2023
@dbeatty10 dbeatty10 mentioned this pull request Dec 13, 2023
Open
1 task
@dbeatty10 dbeatty10 marked this pull request as ready for review December 13, 2023 16:55
@dbeatty10 dbeatty10 requested a review from a team as a code owner December 13, 2023 16:55
@matthewshaver
Copy link
Contributor

Thank you @dbeatty10

@matthewshaver matthewshaver merged commit 3b8ae01 into current Dec 13, 2023
6 of 7 checks passed
@matthewshaver matthewshaver deleted the dbeatty/update-incremental-strategies branch December 13, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that the valid and default strategies are up-to-date and accurate per adapter
2 participants
@dbeatty10 @matthewshaver