-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revise keyboard shortcut page #4630
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @mirnawong1 thank you for doing this!
Deployment failed with the following error:
|
fix failure
website/docs/docs/build/dbt-tips.md
Outdated
|
||
You can also learn about the default dbt Cloud IDE [keyboard shortcuts](/docs/cloud/dbt-cloud-ide/keyboard-shortcuts) to help make development more productive and easier for everyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language here coupled with the sentence above makes it seem like the keyboard shortcuts should be on this page, but the link opens a new page. Might be beneficial to clarify that.
This is probably a project for another day, but this page feels really disjointed. There's no flow or sense to the information. Maybe long term this could be broken up and put in the FAQs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tweaked it a little and added more context. however, feel free to open up an issue so we address this later!
@@ -44,7 +44,7 @@ To improve your experience using dbt Cloud, we suggest that you turn off ad bloc | |||
|
|||
## dbt Cloud IDE features | |||
|
|||
The dbt Cloud IDE comes with [tips](/docs/cloud/dbt-cloud-ide/dbt-cloud-tips) and [features](/docs/cloud/dbt-cloud-ide/ide-user-interface) that make it easier for you to develop, build, compile, run, and test data models. | |||
The dbt Cloud IDE comes with [tips](/docs/build/dbt-tips) and [features](/docs/cloud/dbt-cloud-ide/ide-user-interface) that make it easier for you to develop, build, compile, run, and test data models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing on the tips page that points out anything related to the IDE. Maybe this should be the keyboard shortcuts link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging this now @ernestoongaro ! thank you for the review @matthewshaver |
this pr revamps the keyboard shortcuts into its own page and a table format. it also moves the tips and tricks page under 'build your dag' to emcompass cloud and core users since the content is applicable to both.
Resolves #4607