Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prod settings image #4625

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

MitchellBarker
Copy link
Contributor

@MitchellBarker MitchellBarker commented Dec 11, 2023

What are you changing in this pull request and why?

We've changed the UI for checking production in an env. This is because we're very soon releasing a 'staging' environment as well.

Could be better, but we're releasing the new staging type soon, so this will be fine temporarily imo:
Screenshot 2023-12-11 at 1 08 49 PM

Checklist

@MitchellBarker MitchellBarker requested a review from a team as a code owner December 11, 2023 19:07
Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 8:51pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 11, 2023
@matthewshaver
Copy link
Contributor

matthewshaver commented Dec 11, 2023

Thank you @MitchellBarker ! Is this good to go live now or in the future?

@MitchellBarker
Copy link
Contributor Author

@matthewshaver It's good as of the release today!

@MitchellBarker
Copy link
Contributor Author

To be clear, I can't merge this, so @matthewshaver if you could 🙏
Screenshot 2023-12-14 at 9 32 28 AM

@matthewshaver matthewshaver merged commit 8ebaa37 into current Dec 14, 2023
7 checks passed
@matthewshaver matthewshaver deleted the mbarker/cc-838-update-prod-settings branch December 14, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants