-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out configuration change monitoring from materialized views #4610
Merged
matthewshaver
merged 12 commits into
current
from
content/model-config/on-configuration-change
Dec 18, 2023
Merged
Break out configuration change monitoring from materialized views #4610
matthewshaver
merged 12 commits into
current
from
content/model-config/on-configuration-change
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
size: medium
This change will take up to a week to address
labels
Dec 7, 2023
…" links to be consistent
dbeatty10
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the following previews look great 🚀
…ation-change' into content/model-config/on-configuration-change
--- | ||
|
||
:::info | ||
This functionality is currently only supported for [materialized views](/docs/build/materializations#materialized-view) on a subset of adapters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
This functionality is currently only supported for [materialized views](/docs/build/materializations#materialized-view) on a subset of adapters | |
This functionality is currently only supported for [materialized views](/docs/build/materializations#materialized-view) on a subset of adapters. |
matthewshaver
approved these changes
Dec 18, 2023
matthewshaver
deleted the
content/model-config/on-configuration-change
branch
December 18, 2023 20:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
size: medium
This change will take up to a week to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Configuration change docs are currently embedded in the materialized view docs and are not intuitively reusable everywhere. This was done because this functionality was first built for materialized views, but it's not necessarily specific to materialized views.
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js