Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out configuration change monitoring from materialized views #4610

Merged
merged 12 commits into from
Dec 18, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Dec 7, 2023

What are you changing in this pull request and why?

Configuration change docs are currently embedded in the materialized view docs and are not intuitively reusable everywhere. This was done because this functionality was first built for materialized views, but it's not necessarily specific to materialized views.

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

@mikealfare mikealfare self-assigned this Dec 7, 2023
Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 8:47pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Dec 7, 2023
@mikealfare mikealfare marked this pull request as ready for review December 13, 2023 20:27
@mikealfare mikealfare requested review from dataders and a team as code owners December 13, 2023 20:27
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---

:::info
This functionality is currently only supported for [materialized views](/docs/build/materializations#materialized-view) on a subset of adapters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This functionality is currently only supported for [materialized views](/docs/build/materializations#materialized-view) on a subset of adapters
This functionality is currently only supported for [materialized views](/docs/build/materializations#materialized-view) on a subset of adapters.

@matthewshaver matthewshaver merged commit 7002e59 into current Dec 18, 2023
7 checks passed
@matthewshaver matthewshaver deleted the content/model-config/on-configuration-change branch December 18, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants