Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing tests to data-tests #4592

Merged
merged 57 commits into from
Dec 14, 2023
Merged

Changing tests to data-tests #4592

merged 57 commits into from
Dec 14, 2023

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Dec 5, 2023

What are you changing in this pull request and why?

There is a new test type coming soon so much of the existing test content needs to be updated to data test. This updates docs and reference pages, updates links, and adds redirects.

This only updates existing pages. New pages featuring the new test type will come in a separate PR

In the bodies of these pages, I updated some of the mentions of tests to data tests to remove ambiguity, but not every instance needs to be updated.

Checklist

@matthewshaver matthewshaver requested a review from a team as a code owner December 5, 2023 20:00
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 1:18pm

@github-actions github-actions bot added content Improvements or additions to content developer blog This content fits on the developer blog. guides Knowledge best suited for Guides size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs and removed content Improvements or additions to content developer blog This content fits on the developer blog. guides Knowledge best suited for Guides labels Dec 5, 2023
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Dec 5, 2023
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall!

Spot-checked one of the links and it worked.

Also quickly reviewed the non-link changes. Only noticed on piece amiss and made a suggestion.

Assuming you'll adopt that suggestion, approved.

website/docs/reference/data-test-configs.md Outdated Show resolved Hide resolved
website/docs/best-practices/custom-generic-tests.md Outdated Show resolved Hide resolved
website/docs/best-practices/custom-generic-tests.md Outdated Show resolved Hide resolved
website/docs/best-practices/custom-generic-tests.md Outdated Show resolved Hide resolved
website/docs/docs/build/data-tests.md Outdated Show resolved Hide resolved
website/docs/docs/build/data-tests.md Outdated Show resolved Hide resolved
website/docs/terms/data-wrangling.md Outdated Show resolved Hide resolved
website/docs/terms/primary-key.md Outdated Show resolved Hide resolved
website/docs/terms/primary-key.md Outdated Show resolved Hide resolved
website/docs/terms/surrogate-key.md Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
Adding [tests](/docs/build/tests) to a project helps validate that your models are working correctly.
Adding [tests](/docs/build/data-tests) to a project helps validate that your models are working correctly.

To add tests to your project:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be another page we take a look at when we add unit testing content

@matthewshaver matthewshaver merged commit dd853c9 into current Dec 14, 2023
4 checks passed
@matthewshaver matthewshaver deleted the data-tests branch December 14, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants