Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add materialized view configuration for postgres #4590

Merged
merged 18 commits into from
Dec 13, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Dec 5, 2023

What are you changing in this pull request and why?

I'm updating the configuration documentation for materialized views in dbt-postgres. We didn't initially support swapping materialized views with non-materialized views (e.g. table, view, etc.) in 1.6. We now support that for 1.7. While making these updates, I also implemented a structure that aligns with the structure I used for dbt-bigquery.

Checklist

@mikealfare mikealfare self-assigned this Dec 5, 2023
@mikealfare mikealfare requested review from dataders and a team as code owners December 5, 2023 18:11
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:28pm

@mikealfare mikealfare requested review from Fleid and dbeatty10 December 5, 2023 18:11
@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Dec 5, 2023
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs are super helpful! Learned a lot reading them 🧠

I checked out the preview and I left some comments.

The content style guide doesn't cover how we want to display data types, so not sure which of these variants that we want to use:

  • boolean
  • BOOLEAN
  • <boolean>
  • <BOOLEAN>
  • etc.

So I'll leave that part for a member of the Docs team to cover.

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Dec 7, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Dec 7, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Dec 7, 2023
@matthewshaver matthewshaver merged commit 6218c2c into current Dec 13, 2023
7 checks passed
@matthewshaver matthewshaver deleted the content/materialized-views/postgres branch December 13, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants