-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add materialized view configuration for BigQuery #4578
Add materialized view configuration for BigQuery #4578
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good in the preview 👍
I didn't verify the code examples or the key technical details.
My main feedback is that:
- it would be nice to make the table less wide
- consider lowercase or sentence case for
YES
/NO
, and potentially others
These are nits, and I'm checking off the "Review by DX" box.
p.s. One thing I'd recommend is changing Jinja booleans to lowercase (true
/ false
). I've seen it be a problem in the past, but maybe it's okay now 🤷
Note:
The special constants true, false, and none are indeed lowercase. Because that caused confusion in the past, (True used to expand to an undefined variable that was considered false), all three can now also be written in title case (True, False, and None). However, for consistency, (all Jinja identifiers are lowercase) you should use the lowercase versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the assumption that this comment will be resolved somehow.
Co-authored-by: Doug Beatty <[email protected]>
What are you changing in this pull request and why?
Add configuration options for materialized views in BigQuery. This corresponds to new functionality that was added to
dbt-bigquery
inv1.7
.Checklist