Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding landing pages for autogenerated FAQ directories #4560

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Adding landing pages for autogenerated FAQ directories #4560

merged 6 commits into from
Nov 30, 2023

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Nov 30, 2023 •
edited
Loading

Closes #2748

What are you changing in this pull request and why?

Adding a page that will hopefully add a landing page. This will ensure breadcrumbs work which helps with SEO and will help @kbrock91 be able to link to a section in the FAQs when necessary.

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to the deleted page

@runleonarun
Create _category_.json
dcf18ea 
testing ways to add landing pages to autgen content
@runleonarun runleonarun requested a review from a team as a code owner November 30, 2023 16:43
@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 6:48pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Nov 30, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Nov 30, 2023
@runleonarun runleonarun changed the title Create _category_.json Adding landing pages for autogenerated FAQ directories Nov 30, 2023
@runleonarun runleonarun enabled auto-merge (squash) November 30, 2023 18:37
@runleonarun runleonarun merged commit 7fc3cbf into current Nov 30, 2023
7 checks passed
@runleonarun runleonarun deleted the runleonarun-patch-12 branch November 30, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQs: Can we add landing pages for FAQ categories?
2 participants
@runleonarun @matthewshaver