Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-follows for MS Fabric docs #4538

Merged
merged 26 commits into from
Nov 29, 2023
Merged

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Nov 27, 2023

What are you changing in this pull request and why?

Microsoft Fabric docs fast-follows

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

@nghi-ly nghi-ly requested a review from dataders November 27, 2023 20:13
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 10:43pm

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Nov 27, 2023
@nghi-ly nghi-ly requested a review from a team as a code owner November 27, 2023 20:17
@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides labels Nov 27, 2023
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! feel free to adress my comment in this PR or in a follow-on

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Nov 29, 2023
@@ -54,8 +54,8 @@ A public preview of Microsoft Fabric in dbt Cloud is now available!
CREATE TABLE dbo.customers
(
[ID] [int],
[FIRST_NAME] [varchar] (8000),
[LAST_NAME] [varchar] (8000)
\[FIRST_NAME] [varchar](8000),
Copy link
Contributor Author

@nghi-ly nghi-ly Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line [FIRST_NAME] [varchar](8000), in the code block doesn't render properly:

Screenshot 2023-11-29 at 10 03 23 AM

to fix this, i needed to escape the [ character for all instances in the code block

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nghi-ly! :shipit:

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great just two non blocking comments!

@@ -54,8 +54,8 @@ A public preview of Microsoft Fabric in dbt Cloud is now available!
CREATE TABLE dbo.customers
(
[ID] [int],
[FIRST_NAME] [varchar] (8000),
[LAST_NAME] [varchar] (8000)
\[FIRST_NAME] [varchar](8000),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@@ -108,6 +108,9 @@ A public preview of Microsoft Fabric in dbt Cloud is now available!
2. Enter a project name and click **Continue**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super important, but to fix the code syntax in GitHub, you can add a space before ``` on line 101 (the code is light blue but should have syntax highlighting)

@nghi-ly nghi-ly enabled auto-merge November 29, 2023 22:39
@nghi-ly nghi-ly merged commit b5c27c9 into current Nov 29, 2023
4 checks passed
@nghi-ly nghi-ly deleted the ly-docs-fast-follow-ms-fabric branch November 29, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants