-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast-follows for MS Fabric docs #4538
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/microsoft-fabric-support-rn.md
Outdated
Show resolved
Hide resolved
…soft-fabric-support-rn.md typo
…ocs.getdbt.com into ly-docs-fast-follow-ms-fabric
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! feel free to adress my comment in this PR or in a follow-on
website/docs/docs/cloud/connect-data-platform/connect-microsoft-fabric.md
Show resolved
Hide resolved
@@ -54,8 +54,8 @@ A public preview of Microsoft Fabric in dbt Cloud is now available! | |||
CREATE TABLE dbo.customers | |||
( | |||
[ID] [int], | |||
[FIRST_NAME] [varchar] (8000), | |||
[LAST_NAME] [varchar] (8000) | |||
\[FIRST_NAME] [varchar](8000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @nghi-ly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great just two non blocking comments!
website/docs/docs/cloud/connect-data-platform/connect-microsoft-fabric.md
Show resolved
Hide resolved
@@ -54,8 +54,8 @@ A public preview of Microsoft Fabric in dbt Cloud is now available! | |||
CREATE TABLE dbo.customers | |||
( | |||
[ID] [int], | |||
[FIRST_NAME] [varchar] (8000), | |||
[LAST_NAME] [varchar] (8000) | |||
\[FIRST_NAME] [varchar](8000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
@@ -108,6 +108,9 @@ A public preview of Microsoft Fabric in dbt Cloud is now available! | |||
2. Enter a project name and click **Continue**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super important, but to fix the code syntax in GitHub, you can add a space before ```
on line 101 (the code is light blue but should have syntax highlighting)
What are you changing in this pull request and why?
Microsoft Fabric docs fast-follows
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js