Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding badge component #4535

Merged
merged 2 commits into from
Nov 27, 2023
Merged

adding badge component #4535

merged 2 commits into from
Nov 27, 2023

Conversation

mirnawong1
Copy link
Contributor

this pr adds the 'beta' badge/pill to the extended attributes beta section.

@mirnawong1 mirnawong1 requested a review from a team as a code owner November 27, 2023 16:29
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 4:50pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Nov 27, 2023
@mirnawong1
Copy link
Contributor Author

i removed the 'beta' callout because it seemed redundant

@mirnawong1 mirnawong1 enabled auto-merge November 27, 2023 16:55
@matthewshaver
Copy link
Contributor

Just one little thing I noticed - with the beta pill next to the feature, it copies the link and adds a - at the end https://docs-getdbt-com-git-mwong-add-beat-dbt-labs.vercel.app/docs/dbt-cloud-environments#extended-attributes-

If I remove the - it still directs to the right location, but curious to know if the extra character at the end will cause problems when the beta pill is removed for people who have it linked or bookmarked with the -

@mirnawong1 mirnawong1 merged commit b7d3002 into current Nov 27, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the mwong-add-beat branch November 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirnawong1 @matthewshaver