Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need successful runs for changes to documentation #4508

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

runleonarun
Copy link
Collaborator

Closes #4491

What are you changing in this pull request and why?

Makign a change to outline that you need successful runs to have docs updated.

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to the deleted page

@runleonarun runleonarun requested a review from a team as a code owner November 18, 2023 01:13
Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 0:14am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. and removed Docs team Authored by the Docs team @dbt Labs labels Nov 18, 2023
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Nov 20, 2023
adding to the top as well
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @runleonarun and a small non blocker sugg to add this important tidbit at the top too

@runleonarun runleonarun enabled auto-merge (squash) November 21, 2023 00:00
@runleonarun runleonarun merged commit 30441f9 into current Nov 21, 2023
7 checks passed
@runleonarun runleonarun deleted the runleonarun-patch-12 branch November 21, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add note view cloud docs page
2 participants