-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need successful runs for changes to documentation #4508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
size: x-small
This change will take under 3 hours to fix.
and removed
Docs team
Authored by the Docs team @dbt Labs
labels
Nov 18, 2023
adding to the top as well
mirnawong1
reviewed
Nov 20, 2023
website/docs/docs/collaborate/cloud-build-and-view-your-docs.md
Outdated
Show resolved
Hide resolved
mirnawong1
reviewed
Nov 20, 2023
website/docs/docs/collaborate/cloud-build-and-view-your-docs.md
Outdated
Show resolved
Hide resolved
mirnawong1
reviewed
Nov 20, 2023
website/docs/docs/collaborate/cloud-build-and-view-your-docs.md
Outdated
Show resolved
Hide resolved
mirnawong1
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @runleonarun and a small non blocker sugg to add this important tidbit at the top too
love it Co-authored-by: mirnawong1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
size: x-small
This change will take under 3 hours to fix.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4491
What are you changing in this pull request and why?
Makign a change to outline that you need successful runs to have docs updated.
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js
Removing or renaming existing pages (delete if not applicable):
website/sidebars.js
website/static/_redirects
npm run build
to update the links that point to the deleted page