Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dremio Lakehouse Guide #4485

Merged
merged 23 commits into from
Nov 16, 2023
Merged

Dremio Lakehouse Guide #4485

merged 23 commits into from
Nov 16, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

This is the Dremio dbt Core setup tutorial per https://dbt-labs.slack.com/archives/C02NCQ9483C/p1698980634197409

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

@matthewshaver matthewshaver requested a review from a team as a code owner November 16, 2023 00:37
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 9:32pm

@github-actions github-actions bot added size: medium This change will take up to a week to address content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs and removed size: medium This change will take up to a week to address labels Nov 16, 2023
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Nov 16, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great @matthewshaver , left some feedback on this and let me know if you have any questions at all!

also, do we want to add their logo?

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions.

website/docs/guides/dremio-lakehouse.md Outdated Show resolved Hide resolved
website/docs/guides/dremio-lakehouse.md Outdated Show resolved Hide resolved
website/docs/guides/dremio-lakehouse.md Outdated Show resolved Hide resolved
website/docs/guides/dremio-lakehouse.md Outdated Show resolved Hide resolved
website/docs/guides/dremio-lakehouse.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@matthewshaver matthewshaver dismissed mirnawong1’s stale review November 16, 2023 21:34

Rolled in the changes

@matthewshaver matthewshaver merged commit 503bb63 into current Nov 16, 2023
7 checks passed
@matthewshaver matthewshaver deleted the dremio-qs branch November 16, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants