-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples for dbt deps --add-package
#4470
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for creating this PR @dbeatty10. While you're on this, the doc mentions:
I could be wrong, but by glancing at the code, it seems to me that this is inaccurate. The correct statement should be along the lines of:
Note: I actually like this "actual behavior" better than the behavior implied by the documentation. However, I don't see the need for both the flags There is also a typo "depenedencies.yml" on the page. |
fix typo on dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dbeatty10
@seub thanks for taking a look at this PR and making these suggestions 🏆 @mirnawong1 fixed the spelling of "dependencies" within 5e17f75. I've opened this issue to consider your other suggestions: #4481 |
@seub also opened this feature request as well: dbt-labs/dbt-core#9100 |
Thank you @dbeatty10 ! 🙏 |
Preview
What are you changing in this pull request and why?
Fixing the code examples per dbt-labs/dbt-core#9076 by using test examples from dbt-labs/dbt-core#8408
Checklist