Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating order of examples #4456

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Updating order of examples #4456

merged 2 commits into from
Nov 13, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Standardizes the project.yml file as the first example on a few pages where it's listed after the models example.

Closes #4417

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner November 13, 2023 19:31
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:19pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Nov 13, 2023
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much easier to read! Only one comment for Analyses here is there no dbt_project example?

@matthewshaver
Copy link
Contributor Author

Much easier to read! Only one comment for Analyses here is there no dbt_project example?

I'll ask in a follow up - this doesn't have one in prod today so I'm not sure if it's missing or not required

@matthewshaver matthewshaver merged commit bd154df into current Nov 13, 2023
5 checks passed
@matthewshaver matthewshaver deleted the project-order branch November 13, 2023 22:19
@dbeatty10
Copy link
Contributor

Much easier to read! Only one comment for Analyses here is there no dbt_project example?

I'll ask in a follow up - this doesn't have one in prod today so I'm not sure if it's missing or not required

Good eyes @runleonarun!

The reason is that analyses can't be configured within dbt_project.yml:

There's a distinction between attributes we call "configs" and attributes we call "properties," in that "configs" can be set for many resources at once in dbt_project.yml, and "properties" can only be set for one resource at a time. The fact is that macros and analyses only have properties, and that's why they cannot be configured from dbt_project.yml.

@runleonarun
Copy link
Collaborator

@dbeatty10 always such a great teacher! Thanks for the explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize the order of code examples for dbt_project.yml vs. properties.yml
3 participants