Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Layer configs for dbt_project.yml #4442

Merged
merged 7 commits into from
Nov 16, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Nov 11, 2023

Resolves #4436
Resolves #4441

Previews

What are you changing in this pull request and why?

The only substantive change is in e40903c:

image

The rest of the diff is covered by 83a2e62, which was a duplication of the spec from v1.6 into v1.7.

To keep this PR small and easy to merge, deferring to #3957 to flesh out the other relevant pages for the semantic model configs and metric configs. As part of #3957, this page should be updated with links to the actual config pages once they are created.

Other

Opened #4463 to figure out how many versions back we want to add metrics:.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • I have checked that the previews render correctly across versions 1.6 and 1.7
  • I have confirmed that these config options work in 1.7

Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 3:27pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Nov 11, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dbeatty10 happy to approve this but first wanted to double check if this semantic model page/section should link to this page so it takes users to a real example?

Configure semantic models in a YAML file within your dbt project directory.

@dbeatty10
Copy link
Contributor Author

hey @dbeatty10 happy to approve this but first wanted to double check if this semantic model page/section should link to this page so it takes users to a real example?

Configure semantic models in a YAML file within your dbt project directory.

Yes, this is a great idea 🧠

I'd suggest adding that link in a separate follow-up PR though. The key question to consider in that PR would be: which page(s) should it link to?

#3957 is proposing adding a page for semantic models that is analogous to model configurations. I'm thinking that would be the best one to link to.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dbeatty10 dbeatty10 merged commit f45199d into current Nov 16, 2023
4 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty/semantic-layer-dbt-project-config branch November 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics: config to dbt_project.yml page Add semantic-models: config to dbt_project.yml page
2 participants