-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Layer configs for dbt_project.yml
#4442
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @dbeatty10 happy to approve this but first wanted to double check if this semantic model page/section should link to this page so it takes users to a real example?
Configure semantic models in a YAML file within your dbt project directory.
Yes, this is a great idea 🧠 I'd suggest adding that link in a separate follow-up PR though. The key question to consider in that PR would be: which page(s) should it link to? #3957 is proposing adding a page for semantic models that is analogous to model configurations. I'm thinking that would be the best one to link to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Resolves #4436
Resolves #4441
Previews
What are you changing in this pull request and why?
The only substantive change is in e40903c:
The rest of the diff is covered by 83a2e62, which was a duplication of the spec from v1.6 into v1.7.
To keep this PR small and easy to merge, deferring to #3957 to flesh out the other relevant pages for the semantic model configs and metric configs. As part of #3957, this page should be updated with links to the actual config pages once they are created.
Other
Opened #4463 to figure out how many versions back we want to add
metrics:
.Checklist