Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callout snippet for properties and configs #4439

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Callout snippet for properties and configs #4439

merged 9 commits into from
Nov 13, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Nov 10, 2023 •
edited
Loading

Previews

What are you changing in this pull request and why?

These changes were authored by @mirnawong1 as part of #3989.

This adds a common callout about properties vs. configs near the top of the following pages:

🎩

When rendered, the snippet generally looks like this:

image

Checklist

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 9:48am

@github-actions github-actions bot added the content Improvements or additions to content label Nov 10, 2023
@dbeatty10 dbeatty10 changed the title Dbeatty/config properties callout Callout snippet for properties and configs Nov 10, 2023
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Nov 10, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Nov 10, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review November 10, 2023 22:36
@dbeatty10 dbeatty10 requested a review from a team as a code owner November 10, 2023 22:36
mirnawong1
mirnawong1 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @dbeatty10 !

@mirnawong1 mirnawong1 enabled auto-merge November 13, 2023 09:36
@mirnawong1 mirnawong1 merged commit 0cb4856 into current Nov 13, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/config-properties-callout branch November 13, 2023 09:48
@dbeatty10 dbeatty10 mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1