Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glue is trusted #4437

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Glue is trusted #4437

merged 10 commits into from
Nov 17, 2023

Conversation

dataders
Copy link
Contributor

What are you changing in this pull request and why?

resolves: #4091

Checklist

  • dbt-glue repo has PR CI checks enabled by "ok to test" label
  • all tests available in dbt Labs provided suite are present, with those don't pass commented out

@dataders dataders requested a review from a team as a code owner November 10, 2023 20:41
@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 10:42am

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Nov 10, 2023
mirnawong1
mirnawong1 requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dataders , left a comment regarding the link. also since the trusted platforms are for dbt core, do you think they should have the asterisk? trying to understand what it's use is for.

@dataders
Copy link
Contributor Author

hey @dataders , left a comment regarding the link. also since the trusted platforms are for dbt core, do you think they should have the asterisk? trying to understand what it's use is for.

Are you saying that the asterisk footnote saying that "this adapter is only for core" is redundant given that Trusted adapters are Core only?

image

@dataders dataders requested a review from mirnawong1 November 15, 2023 23:29
@mirnawong1
Copy link
Contributor

mirnawong1 commented Nov 16, 2023 •
edited
Loading

that's right @dataders ! it looks like the footnote was removed already though in the live page for trusted and verified adapters? but other pages have the asterisks so its a little inconsistent - I've removed the asterisks and footnote - i hope that's ok? let me know if you prefer the footnote or asterisks.

i have approved this for you to merge.

Screenshot 2023-11-16 at 09 46 04

mirnawong1
mirnawong1 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @dataders !

@mirnawong1
Copy link
Contributor

going to merge this @dataders since it looks like it's final! however, please let me know if you disagree with anything!

@mirnawong1 mirnawong1 enabled auto-merge November 17, 2023 10:37
@mirnawong1 mirnawong1 merged commit e1fca0f into current Nov 17, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the glue_is_trusted branch November 17, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AWS Glue adapter to trusted list
2 participants
@dataders @mirnawong1