-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove callout and add tabs as examples #4402
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty @mirnawong1! Added a few comments and tweaks but this is going to be so much better 😍
Co-authored-by: Joel Labes <[email protected]>
</File> | ||
|
||
This would return `analytics.finance.sales_dashboard` in the database, instead of the default `analytics.finance.sales_metrics`. | ||
</TabItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or is it analytics.finance.unique_order_id_test
? this makes me think it's the _ one?
</File> | ||
|
||
This would return `analytics.finance.sales_dashboard` in the database, instead of the default `analytics.finance.sales_metrics`. | ||
</TabItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we add config or is that only for properties.yml
?
hey @joellabes thank you so much for this! I've made changes to it and added items you suggested. i did ask about tests in custom database to confirm, but i also added an example just in case. also i have a question below for you if you can clarify because i see some do and some don't based on the issues you linked above. thank you!
|
…cs.getdbt.com into mwong-remove-callout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better! A couple of tweaks on the net-new stuff again
|
||
<TabItem value="test" label="Tests"> | ||
|
||
Configure a test's alias in your `dbt_project.yml` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't create tests in a dbt_project.yml, this would be in a schema.yml file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! wait is schema.yml the same as properties.yml? https://docs.getdbt.com/reference/configs-and-properties#schemayml-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
+database: staging | ||
``` | ||
|
||
This would result in the generated relation being located in the `staging` database, so the full relation name would be `staging.finance.product_categories_data`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did the _data
suffix come from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh fudge! i think i copied the over from alias and didnt remove the _data bit
Yes:
|
…cs.getdbt.com into mwong-remove-callout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @joellabes ! ok added your feedback now - can you re-review when you have a sec?
going to enable automerge in case it's all good to go |
addressing @joellabes' request to remove old callouts for alias, database, and schema pages. also added example tabs at the beginning to help provide users with more example at the beginning of the doc