Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tableau.md #4380

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Update tableau.md #4380

merged 2 commits into from
Nov 1, 2023

Conversation

rpourzand
Copy link
Contributor

Adding note about versions we just tested and referencing the cumulative metric w/ grain issue to remind people in Tableau docs as well

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

Adding note about versions we just tested and referencing the cumulative metric w/ grain issue to remind people in Tableau docs as well
@rpourzand rpourzand requested a review from mirnawong1 October 31, 2023 22:05
@rpourzand rpourzand requested a review from a team as a code owner October 31, 2023 22:05
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 9:52am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 31, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rpourzand , thank you so much for opening this up! i slightly tweaked the wording. will go ahead and merge this for you but please let me know if you have strong opinions about the suggestion:

In any of our Semantic Layer interfaces (not only Tableau), you must include a time dimension when working with any cumulative metric that has a time window or granularity.

@mirnawong1 mirnawong1 enabled auto-merge November 1, 2023 09:45
@mirnawong1 mirnawong1 merged commit e2eff6c into current Nov 1, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-tableau-updates branch November 1, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants