Ensure we load stoplight css first so that base styles get overridden #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
size: small
runleonarun
reviewed
Oct 26, 2023
There was a problem hiding this comment.
@GideonShils Looks good, but I don't see any changes in the api fonts. Is there follow-up work that would need to happen?
|
@runleonarun ahh yeah, this PR just fixes the header fonts so that we're not overriding anything unexpectedly. The actual docs are still using the default Stoplight CSS. I'd say if we want to change things up there, let's do it as a follow up |
runleonarun
approved these changes
Oct 26, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4346
What are you changing in this pull request and why?
Previously the header on the API docs pages was using the wrong font. This was because the Stoplight styles used for rendering API docs were loading last, and were therefore overriding the page level font. This PR swaps the css to load using the standard docusaurus pattern so that the styles load first, and are overridden later by the expected font styling.
Checklist