Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to email/slack job notifications #4347

Merged
merged 45 commits into from
Nov 6, 2023
Merged

Updates to email/slack job notifications #4347

merged 45 commits into from
Nov 6, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Oct 26, 2023 •
edited
Loading

What are you changing in this pull request and why?

Rewrote the https://docs.getdbt.com/docs/deploy/job-notifications page:

  • add content about external emails
  • add content about multiple slack channels
  • updated screenshots for new UI, removed old ones
  • removed duplicate content in an FAQ, removed snippet, added redirect

Checklist

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@nghi-ly nghi-ly requested a review from a team as a code owner October 26, 2023 17:16
@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 11:24pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Oct 26, 2023
@nghi-ly nghi-ly requested a review from GideonShils October 26, 2023 19:15
GideonShils
GideonShils reviewed Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@GideonShils GideonShils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few initial comments! Also, can we use a screenshot that doesn't include my personal email address 😂. Happy to send some over if helpful

website/docs/docs/deploy/job-notifications.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/job-notifications.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/job-notifications.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/job-notifications.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/job-notifications.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/job-notifications.md Outdated Show resolved Hide resolved
@nghi-ly nghi-ly requested a review from GideonShils November 6, 2023 20:14
@nghi-ly nghi-ly requested a review from matthewshaver November 6, 2023 23:21
@nghi-ly nghi-ly merged commit 08b89d4 into current Nov 6, 2023
4 checks passed
@nghi-ly nghi-ly deleted the ly-docs-job-notification-updates branch November 6, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@GideonShils GideonShils GideonShils approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nghi-ly @GideonShils @matthewshaver