Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content-style-guide.md #4341

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Update content-style-guide.md #4341

merged 8 commits into from
Nov 2, 2023

Conversation

mirnawong1
Copy link
Contributor

adding this official stance to the style guide to ensure correct terminology is used

adding this official stance to the style guide
@mirnawong1 mirnawong1 requested a review from a team as a code owner October 26, 2023 11:23
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 4:59pm

@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Oct 26, 2023
@@ -307,10 +307,10 @@ A numbered list following an H2 heading:
## Tables
Tables provide a great way to present complex information and can help the content be more scannable for users, too.

There are many ways to construct a table, like row spanning and cell splitting. Make sure the content is clear, concise, and presents well on the web page (like avoid awkward word wrapping).
There are many ways to construct a table, like row spanning and cell splitting. Make sure the content is clear, concise, and presented well on the web page (like avoiding awkward word wrapping).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid using "like" to present examples.

Suggested change
There are many ways to construct a table, like row spanning and cell splitting. Make sure the content is clear, concise, and presented well on the web page (like avoiding awkward word wrapping).
There are many ways to construct a table, such as row spanning and cell splitting. The content should be clear, concise, and presented well on the web page (for example, avoid awkward word wrapping).

Copy link
Contributor Author

@mirnawong1 mirnawong1 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hear you @matthewshaver might be worth discussing with the docs team bc the style guide itself suggests using 'like' (and i was also told to use 'like', 'such as', 'for example', as opposed to 'eg' when i started).

Screenshot 2023-10-27 at 11 48 19

@mirnawong1
Copy link
Contributor Author

hey @matthewshaver , thanks so much for this review! is this good to merge or are there any pending items for me to resolve?

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@runleonarun runleonarun enabled auto-merge (squash) November 2, 2023 16:51
@runleonarun runleonarun merged commit 31c5305 into current Nov 2, 2023
6 checks passed
@runleonarun runleonarun deleted the mirnawong1-patch-5 branch November 2, 2023 16:59
@mirnawong1
Copy link
Contributor Author

thanks so much for merging @runleonarun !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants