Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update set-up-sso-saml-2.0.md #4323

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Update set-up-sso-saml-2.0.md #4323

merged 8 commits into from
Oct 25, 2023

Conversation

BrJan
Copy link
Contributor

@BrJan BrJan commented Oct 24, 2023

Add note on expiring certs

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@BrJan
Update set-up-sso-saml-2.0.md
8689ff4 
Add note on expiring certs
@BrJan BrJan requested a review from a team as a code owner October 24, 2023 20:28
@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 7:55pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed content Improvements or additions to content labels Oct 24, 2023
BrJan
BrJan commented Oct 24, 2023
View reviewed changes
Copy link
Contributor Author

@BrJan BrJan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace Okta admin with IdP admin

mirnawong1
mirnawong1 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @BrJan , looks great! fixed a small typo and it's good to merge!

@matthewshaver matthewshaver merged commit 7484d0b into current Oct 25, 2023
6 checks passed
@matthewshaver matthewshaver deleted the BrJan-patch-2 branch October 25, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver left review comments

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrJan @matthewshaver @mirnawong1