Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package-lock update to deps #4287

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Package-lock update to deps #4287

merged 3 commits into from
Oct 16, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Closes: #4235

Updating dbt deps reference page to reflect new package-lock.yml file generated in v1.7

Checklist

Uncomment if you're publishing docs for a prerelease version of dbt (delete if not applicable):

  • Add versioning components, as described in Versioning Docs

  • Add a note to the prerelease version Migration Guide

  • Review the Content style guide and About versioning so my content adheres to these guidelines.

  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner October 16, 2023 19:56
@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 9:14pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address and removed Docs team Authored by the Docs team @dbt Labs labels Oct 16, 2023
nghi-ly
nghi-ly reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! mostly nits around using present tense vs future tense. it's a best practice in techdocs to be shorter in length and more concise

website/docs/reference/commands/deps.md Outdated Show resolved Hide resolved
website/docs/reference/commands/deps.md Outdated Show resolved Hide resolved
website/docs/reference/commands/deps.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Oct 16, 2023
nghi-ly
nghi-ly approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@matthewshaver matthewshaver merged commit 5c40a44 into current Oct 16, 2023
6 checks passed
@matthewshaver matthewshaver deleted the dbt-deps branch October 16, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.7] dbt deps produces package-lock.yml
2 participants
@matthewshaver @nghi-ly