Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slight rephrasing on 1.7 migration guide for clarity #4279

Merged
merged 4 commits into from
Oct 16, 2023
Merged

slight rephrasing on 1.7 migration guide for clarity #4279

merged 4 commits into from
Oct 16, 2023

Conversation

graciegoheen
Copy link
Collaborator

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@graciegoheen graciegoheen requested a review from a team as a code owner October 13, 2023 15:20
@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 2:06pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. labels Oct 13, 2023
dbeatty10
dbeatty10 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Added one suggestion for you to consider.

website/docs/guides/migration/versions/00-upgrading-to-v1.7.md Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Oct 15, 2023

You must have Developer access to commit code to dbt-labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/concepts/teams/roles-and-permissions#enterprise-team-account-roles

@matthewshaver matthewshaver merged commit 8055fca into current Oct 16, 2023
6 checks passed
@matthewshaver matthewshaver deleted the update_migration_guide_1.7 branch October 16, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@dbeatty10 dbeatty10 dbeatty10 approved these changes

@runleonarun runleonarun Awaiting requested review from runleonarun

Assignees
No one assigned
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graciegoheen @dbeatty10 @matthewshaver