Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update semantic-models.md #4264

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Update semantic-models.md #4264

merged 2 commits into from
Oct 12, 2023

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Oct 12, 2023 •
edited
Loading

Closes #4127

What are you changing in this pull request and why?

Removes "optional" and adds default for create_metric

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@runleonarun runleonarun requested a review from a team as a code owner October 12, 2023 00:18
@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 0:33am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Oct 12, 2023
@runleonarun runleonarun merged commit 9308a06 into current Oct 12, 2023
6 checks passed
@runleonarun runleonarun deleted the runleonarun-patch-12 branch October 12, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

automatically create metrics from semantic model measures, using create_metric: true from dbt-core PR #8310
2 participants
@runleonarun @matthewshaver