Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast-follows for retry #4254

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fast-follows for retry #4254

merged 2 commits into from
Oct 11, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Oct 11, 2023 •
edited
Loading

What are you changing in this pull request and why?

Fixed a few things:

  • replaced result:error with Error
  • added link to the retry API endpoint
  • added pointers to new retry page from two landing pages

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner October 11, 2023 17:44
@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 6:07pm

@nghi-ly nghi-ly requested a review from thorn14 October 11, 2023 17:44
@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Oct 11, 2023
thorn14
thorn14 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@thorn14 thorn14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeeet

@nghi-ly nghi-ly enabled auto-merge October 11, 2023 18:05
@nghi-ly nghi-ly merged commit d880c74 into current Oct 11, 2023
6 checks passed
@nghi-ly nghi-ly deleted the ly-docs-retry-ui-fast-follow branch October 11, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn14 thorn14 thorn14 approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nghi-ly @thorn14