Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci-jobs.md #4250

Closed
wants to merge 8 commits into from
Closed

Update ci-jobs.md #4250

wants to merge 8 commits into from

Conversation

patkearns10
Copy link
Contributor

What are you changing in this pull request and why?

non-native integrations require an extra payload field to kick off the right branch comparison
Slack thread

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@patkearns10
Update ci-jobs.md
28f6018 
non-native integrations require an extra payload field
@patkearns10 patkearns10 requested a review from a team as a code owner October 11, 2023 01:40
@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 4:38am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 11, 2023
knartovich
knartovich approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@knartovich knartovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks again for making this change

@patkearns10
Copy link
Contributor Author

@knartovich - fyi I don't have access to merge!

@knartovich
Copy link
Contributor

@knartovich - fyi I don't have access to merge!

i don't either. the product docs team is a code owner & someone from their team needs to approve the PR first. @nghi-ly can you help us out here?

@knartovich knartovich requested a review from nghi-ly October 13, 2023 14:50
@knartovich
Copy link
Contributor

closing in favor of #4282

@knartovich knartovich closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knartovich knartovich knartovich approved these changes

@nghi-ly nghi-ly Awaiting requested review from nghi-ly

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patkearns10 @knartovich @mirnawong1