Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lint-format.md #4245

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Update lint-format.md #4245

merged 9 commits into from
Oct 11, 2023

Conversation

jeremyyeo
Copy link
Contributor

What are you changing in this pull request and why?

Adding some limitations of our SQLFluff implementation. See internal JIRA: https://dbtlabs.atlassian.net/browse/XP-2679

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@jeremyyeo jeremyyeo requested a review from a team as a code owner October 10, 2023 21:17
@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 9:08am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed content Improvements or additions to content labels Oct 10, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 11, 2023
mirnawong1
mirnawong1 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jeremyyeo , great PR and thanks so much for opening it to flag it to users! def important for them to know about this! going to merge this but let me know if you have any objections to the changes!

@mirnawong1 mirnawong1 enabled auto-merge October 11, 2023 09:01
@mirnawong1 mirnawong1 merged commit cf0a4e1 into current Oct 11, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the jeremyyeo-patch-1 branch October 11, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremyyeo @mirnawong1