Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of "Advice" for when to use materialized views #4223

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 7, 2023

Preview

What are you changing in this pull request and why?

Fix this rendering:
image

Checklist

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 7:34pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 7, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review October 7, 2023 22:34
@dbeatty10 dbeatty10 requested a review from a team as a code owner October 7, 2023 22:34
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! Thanks for fixing this up @dbeatty10 🔥

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! Thank you for fixing this up @dbeatty10 !

@mirnawong1 mirnawong1 enabled auto-merge October 8, 2023 19:21
@mirnawong1 mirnawong1 merged commit def7a61 into current Oct 8, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/fix-mv-advice-rendering branch October 8, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants