Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config for metrics is singular rather than plural #4222

Merged
merged 1 commit into from
Oct 8, 2023
Merged

config for metrics is singular rather than plural #4222

merged 1 commit into from
Oct 8, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 7, 2023 •
edited
Loading

Preview

What are you changing in this pull request and why?

The config key for metrics is singular rather than plural, so we should change "configs" to "config" in the documentation.

Checklist

  • I have tested that the code examples work
  • I have tested that the changes look correct in the Vercel preview
  • Review the Content style guide and About versioning so my content adheres to these guidelines.

@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 10:16pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 7, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review October 7, 2023 23:07
@dbeatty10 dbeatty10 requested a review from a team as a code owner October 7, 2023 23:07
mirnawong1
mirnawong1 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this up @dbeatty10 !

@mirnawong1 mirnawong1 merged commit d45b3e2 into current Oct 8, 2023
9 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/fix-config-key-name branch October 8, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1