Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group config for semantic models #4220

Merged
merged 13 commits into from
Nov 8, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 7, 2023

related to: #3997
related to: #4281

What are you changing in this pull request and why?

  • Fix version blocks for other resource types
  • Match the style for other resource types for models/semantic_models.yml
  • Fix code example in dbt_project.yml to refer to semantic-models (since semantic_models won't work)
  • Simplify the definition by removing an explicit listing of applicable resource types
    • rather than adding the missing ones (like seeds and semantic models)

Other

  • Opened an issue to standardize the order of code examples for dbt_project.yml vs. properties.yml: #4417
  • Opened an issue to figure out: do analyses really have a group config?1 #4416
  • Opened an issue to standardize on <group_name> instead of finance in generic syntax examples #4418

🎩

Previews

v1.7

image

Checklist

  • I have tested that the code examples work
  • I have tested that the changes look correct in the Vercel preview
  • Review the Content style guide and About versioning so my content adheres to these guidelines.

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 8:52pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Oct 7, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Oct 7, 2023
@matthewshaver
Copy link
Contributor

Closing as duplicate. Addressed in #4231

@dbeatty10 dbeatty10 reopened this Nov 8, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Nov 8, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review November 8, 2023 04:09
@dbeatty10 dbeatty10 requested a review from a team as a code owner November 8, 2023 04:09
@matthewshaver matthewshaver merged commit 3f5133c into current Nov 8, 2023
4 checks passed
@matthewshaver matthewshaver deleted the dbeatty/semantic-models-group-config branch November 8, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants