Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry jobs #4213

Merged
merged 27 commits into from
Oct 9, 2023
Merged

Retry jobs #4213

merged 27 commits into from
Oct 9, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Oct 6, 2023

What are you changing in this pull request and why?

Add docs and release notes for Retry jobs:

  • Add new Retry jobs page
  • Update sidebar with new page under Deploy > Monitor jobs and alerts
  • Add release note

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:02pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Oct 6, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Oct 6, 2023
@nghi-ly nghi-ly requested a review from thorn14 October 6, 2023 18:40
Copy link
Contributor

@thorn14 thorn14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Oct 6, 2023
@nghi-ly nghi-ly marked this pull request as ready for review October 6, 2023 18:57
@nghi-ly nghi-ly requested a review from a team as a code owner October 6, 2023 18:58
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nghi-ly! I just have a few suggestions to tighten up a couple of sentences.

I like the use of "modal" here and feel like I've also seen "pop up," but I think we should add modal to our style guide.

website/docs/docs/deploy/retry-jobs.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/retry-jobs.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/retry-jobs.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/retry-jobs.md Outdated Show resolved Hide resolved
…e-retry-support-rn.md

Co-authored-by: Leona B. Campbell <[email protected]>
@nghi-ly nghi-ly requested a review from runleonarun October 9, 2023 18:25
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more non-blocking comment/question. Thanks @nghi-ly! This page will be super helpful!

website/docs/docs/deploy/retry-jobs.md Outdated Show resolved Hide resolved
@nghi-ly nghi-ly merged commit cabb074 into current Oct 9, 2023
3 checks passed
@nghi-ly nghi-ly deleted the ly-docs-rerun branch October 9, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants