Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify copy_partitions #4153

Merged
merged 13 commits into from
Jan 17, 2024
Merged

Clarify copy_partitions #4153

merged 13 commits into from
Jan 17, 2024

Conversation

mwstanleyft
Copy link
Contributor

@mwstanleyft mwstanleyft commented Sep 28, 2023

copy_partitions does not require ingestion time partitioning and is not a legacy mechanism

What are you changing in this pull request and why?

Clarifying when copy_partitions can be used and why it's useful.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Does not require ingestion time partitioning and is not a legacy mechanism
@mwstanleyft mwstanleyft requested review from dataders and a team as code owners September 28, 2023 15:40
@welcome
Copy link

welcome bot commented Sep 28, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed new contributor Label for first-time contributors labels Sep 28, 2023
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 11:18am

@dataders
Copy link
Contributor

@mwstanleyft can you help me with a little more context here? the edit seems as if it's correcting a previously incorrect statement. is this specific to a version of dbt-bigquery or relevant to everyone?

@mwstanleyft
Copy link
Contributor Author

It's relevant to anyone on any version of dbt-bigquery. The old description called this a "legacy" mechanism but it's a fully supported feature of the BigQuery API.

@mirnawong1
Copy link
Contributor

picking this up and asked in slack to confirm: https://dbt-labs.slack.com/archives/C067EUS2D7S/p1704896406558099

Copy link

vercel bot commented Jan 17, 2024

@mirnawong1 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mwstanleyft thanks so much for your patience on this and apologies for the delay here. i appreciate you opening this up to clarify the docs and 've confirmed internally on our end. I will get this merged for you ✨

@mirnawong1 mirnawong1 enabled auto-merge January 17, 2024 11:09
@mirnawong1 mirnawong1 merged commit 02a61ba into dbt-labs:current Jan 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content January-2024 new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants