Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding access to configs #4146

Merged
merged 10 commits into from
Oct 11, 2023
Merged

Expanding access to configs #4146

merged 10 commits into from
Oct 11, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding to the access page per #4075

Also moving the page to the resource configs files

Checklist

  • Add versioning components, as described in Versioning Docs

  • Review the Content style guide and About versioning so my content adheres to these guidelines.

  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@matthewshaver matthewshaver requested a review from a team as a code owner September 27, 2023 19:53
@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 6:52pm

@matthewshaver matthewshaver changed the title Expanding access to configs Expanding access to configs Sep 27, 2023
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Sep 27, 2023
@matthewshaver matthewshaver linked an issue Sep 27, 2023 that may be closed by this pull request
Allow setting access as a config #4075
Closed
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Oct 10, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: large This change will more than a week to address and might require more than one person labels Oct 10, 2023
runleonarun
runleonarun reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver some comments. LMK if you have any questions!

website/docs/reference/resource-configs/access.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/access.md Outdated Show resolved Hide resolved
runleonarun
runleonarun approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewshaver matthewshaver merged commit 890c1c0 into current Oct 11, 2023
6 checks passed
@matthewshaver matthewshaver deleted the access branch October 11, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting access as a config
2 participants
@matthewshaver @runleonarun