Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify service token generation #4142

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Clarify service token generation #4142

merged 6 commits into from
Sep 28, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Sep 27, 2023

What are you changing in this pull request and why?

Clarify service token generation.

  • Add that a Developer license with account admin perms are needed to create one

Slack thread for context: https://dbt-labs.slack.com/archives/C017GDLAF7D/p1695766588444809

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner September 27, 2023 16:36
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 10:20pm

@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs labels Sep 27, 2023
@nghi-ly nghi-ly requested a review from mirnawong1 September 27, 2023 17:06
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nghi-ly , left a comment as i think the acct admin permission link may need double checking with matt and tania. i think they mean rbac group but might be best to double check

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @nghi-ly ! thank you!

@nghi-ly nghi-ly merged commit 89acba3 into current Sep 28, 2023
3 checks passed
@nghi-ly nghi-ly deleted the ly-docs-tokens branch September 28, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants