Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate 1.1 and changelog from docs #4140

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Deprecate 1.1 and changelog from docs #4140

merged 3 commits into from
Sep 27, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Deprecating 1.1 from docs:

  • Removes 1.1 from versions dropdown
  • Marked 1.1 as deprecated in version table
  • Removes version blocks and content where lastVersion="1.1"
  • Removes version blocks but leaves content where firstVersion="1.1"
  • Removed page versioning restrictions

Deprecating ChangeLogs

  • Most changelogs were for versions < 1.0
  • removes formatting from all pages
  • If content contained in changelog was not already present in the body of the doc, it has been added. Everything else was removed.
  • A few changelogs existed for more recent versions (1.2, 1.5) and were converted to versionblocks.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested review from dataders and a team as code owners September 27, 2023 14:37
@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 5:28pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person and removed content Improvements or additions to content guides Knowledge best suited for Guides labels Sep 27, 2023
@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs content Improvements or additions to content guides Knowledge best suited for Guides labels Sep 27, 2023
mirnawong1
mirnawong1 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @matthewshaver, looked this over and it all looks good to me!

@matthewshaver matthewshaver merged commit 6e6cc02 into current Sep 27, 2023
7 checks passed
@matthewshaver matthewshaver deleted the 1dot1-deprecation branch September 27, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@dataders dataders Awaiting requested review from dataders

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @mirnawong1