Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial-document-your-models.md #4121

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

olycats
Copy link
Contributor

@olycats olycats commented Sep 24, 2023

Add customers.customer_id from the previous step

What are you changing in this pull request and why?

Quickstart for dbt Cloud and BigQuery
Step 12 Add tests to your models https://docs.getdbt.com/quickstarts/bigquery?step=12
Step 13 Document your models https://docs.getdbt.com/quickstarts/bigquery?step=13

I found that the schema.yml in step 13 is not consistent with step 12.

There is column:customer_id in step 12 but not step 13. I would like it to be added to step 13 as well.

      - name: customer_id
        tests:
          - not_null
          - relationships:
              to: ref('stg_customers')
              field: customer_id

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Add customers.customer_id from the previous step
@olycats olycats requested a review from a team as a code owner September 24, 2023 03:31
@welcome
Copy link

welcome bot commented Sep 24, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel
Copy link

vercel bot commented Sep 24, 2023

@olycats is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed new contributor Label for first-time contributors labels Sep 24, 2023
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Sep 27, 2023 9:55pm

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @olycats! Approving and will merge this change soon!

@runleonarun runleonarun merged commit d25adae into dbt-labs:current Sep 27, 2023
3 checks passed
@mirnawong1 mirnawong1 mentioned this pull request Sep 28, 2023
runleonarun pushed a commit that referenced this pull request Sep 28, 2023
modifying github action to add label new contributor opens a pr _only_
(not closes). this is a result of Leona flagging that since the vercel
migration, the new contributor label was being removed shortly after the
gha adds it. [example
pr](#4121)

cc @runleonarun

this might have something to do with the 'authorize in vercel' workflow
perhaps?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants