Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs.md with more clear node_color info #4120

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

alison985
Copy link
Contributor

@alison985 alison985 commented Sep 23, 2023

What are you changing in this pull request and why?

This mostly updates the documentation of doc to better integrate node_color into the page.

Checklist

@vercel
Copy link

vercel bot commented Sep 23, 2023

@alison985 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 23, 2023
Refer to macro documentation keywords
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 9:56am

@alison985 alison985 marked this pull request as ready for review September 28, 2023 06:55
@alison985 alison985 requested a review from a team as a code owner September 28, 2023 06:55
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @alison985 ! great contribution and i think this reads much clearer - made a small tweak to ensure the link would work for macro properties. will get this merged for you ✨

@mirnawong1 mirnawong1 merged commit 441b642 into dbt-labs:current Sep 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants