-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update custom-aliases: usage methods, File formatting, and version numbers #4119
Conversation
* Updated first version for Dispatch to 1.0. I'm using it in 1.4 so it had to be introduced before what was stated. The `dispatch` doc page says 1.0. I also updated the link to have the in-page reference it seemed to want. I re-titled the section header so it would stand out in the right navigation and be more descriptive. * I added the File macro around two files that were missing it. * I added an example of configuring an alias in YAML instead of Jinja.
@alison985 is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
looping in @matthewshaver as i believe we removed version blocks for versions 1.1 and lower |
remove version block since its available for all current (1.0 is deprecated) |
removing version block as 1.0 is deprecated and this applies to existing version (1.2 and higher)
fix yaml indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @alison985 , thanks again for opening this up and sorry for the delay here. I made some small tweaks (for example, i removed the v1.0 version since we've deprecated 1.0 and the code is supported by the current versions). I'll get this merged for you and appreciate the detailed info! looks great ! ✨
What are you changing in this pull request and why?
dispatch
doc page says 1.0. I also updated the link to have the in-page reference it seemed to want. I re-titled the section header so it would stand out in the right navigation and be more descriptive.Checklist