Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-aliases: usage methods, File formatting, and version numbers #4119

Merged
merged 9 commits into from
Oct 31, 2023

Conversation

alison985
Copy link
Contributor

@alison985 alison985 commented Sep 23, 2023

What are you changing in this pull request and why?

  • Updated first version for Dispatch to 1.0. I'm using it in 1.4 so it had to be introduced before what was stated. The dispatch doc page says 1.0. I also updated the link to have the in-page reference it seemed to want. I re-titled the section header so it would stand out in the right navigation and be more descriptive.
  • I added the File macro around two files that were missing it.
  • I added an example of configuring an alias in YAML instead of Jinja.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

* Updated first version for Dispatch to 1.0. I'm using it in 1.4 so it had to be introduced before what was stated. The `dispatch` doc page says 1.0. I also updated the link to have the in-page reference it seemed to want. I re-titled the section header so it would stand out in the right navigation and be more descriptive.
* I added the File macro around two files that were missing it.
* I added an example of configuring an alias in YAML instead of Jinja.
@vercel
Copy link

vercel bot commented Sep 23, 2023

@alison985 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Sep 23, 2023
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 2:53pm

@alison985 alison985 marked this pull request as ready for review September 28, 2023 06:50
@alison985 alison985 requested a review from a team as a code owner September 28, 2023 06:50
@mirnawong1
Copy link
Contributor

looping in @matthewshaver as i believe we removed version blocks for versions 1.1 and lower

@mirnawong1
Copy link
Contributor

remove version block since its available for all current (1.0 is deprecated)

removing version block as 1.0 is deprecated and this applies to existing version (1.2 and higher)
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @alison985 , thanks again for opening this up and sorry for the delay here. I made some small tweaks (for example, i removed the v1.0 version since we've deprecated 1.0 and the code is supported by the current versions). I'll get this merged for you and appreciate the detailed info! looks great ! ✨

@mirnawong1 mirnawong1 enabled auto-merge October 31, 2023 14:47
@mirnawong1 mirnawong1 merged commit 7560640 into dbt-labs:current Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants